brandboat commented on code in PR #21607:
URL: https://github.com/apache/kafka/pull/21607#discussion_r2879158452
##########
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##########
@@ -34,7 +34,7 @@
"about": "The incarnation id of the broker process." },
{ "name": "Listeners", "type": "[]Listener",
"about": "The listeners of this broker.", "versions": "0+", "fields": [
- { "name": "Name", "type": "string", "versions": "0+", "mapKey": true,
+ { "name": "Name", "type": "string", "versions": "0+",
Review Comment:
Then we have some inconsistencies here, that make me hesitant to move
forward. I'm worried mapKey might be some kind of convention in Kafka, despite
it seeming redundant in our current xxxCollections, many of them don't even use
find/findAll.
Does it make sense to pause here until we understand why it was added in the
first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
