dajac commented on code in PR #21616:
URL: https://github.com/apache/kafka/pull/21616#discussion_r2878302131
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -277,10 +276,14 @@ public GroupCoordinatorService build() {
.withSerializer(new GroupCoordinatorRecordSerde())
.withCompression(Compression.of(config.offsetTopicCompressionType()).build())
.withAppendLingerMs(config.appendLingerMs())
- .withExecutorService(Executors.newFixedThreadPool(
- config.numBackgroundThreads(),
-
ThreadUtils.createThreadFactory("group-coordinator-background-%d", false)
- ))
+ .withExecutorService(
+ new CoordinatorBackgroundThreadPoolExecutor(
Review Comment:
nit: Should we define it before in order to reduce the builder? We could put
it right after creating the processor.
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorBackgroundThreadPoolExecutor.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.coordinator.common.runtime;
+
+import org.apache.kafka.common.utils.ThreadUtils;
+import org.apache.kafka.common.utils.Time;
+
+import java.util.Objects;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.ThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * A {@link ThreadPoolExecutor} that reports metrics.
+ */
+public class CoordinatorBackgroundThreadPoolExecutor extends
ThreadPoolExecutor {
+
+ /**
+ * The time.
+ */
+ private final Time time;
+
+ /**
+ * The coordinator runtime metrics.
+ */
+ private final CoordinatorRuntimeMetrics metrics;
+
+ public CoordinatorBackgroundThreadPoolExecutor(
+ String threadPrefix,
+ int numThreads,
+ Time time,
+ CoordinatorRuntimeMetrics metrics
+ ) {
+ super(
+ numThreads,
+ numThreads,
+ 0L,
+ TimeUnit.MILLISECONDS,
+ new LinkedBlockingQueue<>(),
+ ThreadUtils.createThreadFactory(threadPrefix + "%d", false)
Review Comment:
nit: Should we also ensure that `threadPrefix` is not null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
