see-quick commented on code in PR #21575:
URL: https://github.com/apache/kafka/pull/21575#discussion_r2878165109
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/LogCleanerLagIntegrationTest.java:
##########
@@ -345,6 +598,13 @@ private void closeLog(UnifiedLog log) throws IOException {
logs.remove(log);
}
+ @AfterEach
+ public void cleanup() {
+ for (MetricName metricName :
KafkaYammerMetrics.defaultRegistry().allMetrics().keySet()) {
Review Comment:
Yeah, I can do it. ... but I can see currently in multiple modules I can see
that a lot of Java suites are using porting scala implementation i.e., they
call `kafka.utils.TestUtils.clearYammerMetrics();`. So I wonder here I can do
same (i.e., just use scala version) and create JIRA to migrate this into
TestUtils (i.e., test-common-runtime)? And then just replace all these
`kafka.utils.TestUtils.clearYammerMetrics()` with Java implementation WDYT?
That would avoid a lot of un-necessary changes ... and we can split the work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
