dajac commented on code in PR #21555:
URL: https://github.com/apache/kafka/pull/21555#discussion_r2871204820
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -80,9 +80,14 @@ public class GroupCoordinatorConfig {
public static final int GROUP_COORDINATOR_APPEND_LINGER_MS_DEFAULT = -1;
public static final String GROUP_COORDINATOR_NUM_THREADS_CONFIG =
"group.coordinator.threads";
- public static final String GROUP_COORDINATOR_NUM_THREADS_DOC = "The number
of threads used by the group coordinator.";
+ public static final String GROUP_COORDINATOR_NUM_THREADS_DOC = "The number
of threads used by the group coordinator for processing requests.";
public static final int GROUP_COORDINATOR_NUM_THREADS_DEFAULT = 4;
+ public static final String GROUP_COORDINATOR_NUM_BACKGROUND_THREADS_CONFIG
= "group.coordinator.background.threads";
Review Comment:
I am +1 for adding something but I would do it for the KIP, not for the
config. Hence, I suggest to defer it to another PR. @squah-confluent Could you
please file a ticket so we don't forget about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
