manangupta111 commented on code in PR #21612:
URL: https://github.com/apache/kafka/pull/21612#discussion_r2870944756
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##########
@@ -1944,25 +1965,29 @@ private int deleteSegments(List<LogSegment> deletable,
SegmentDeletionReason rea
* not deletion is enabled, delete any local log segments that are before
the log start offset
*/
public int deleteOldSegments() throws IOException {
+ int deletedSegments;
if (config().delete) {
- return deleteLogStartOffsetBreachedSegments() +
+ deletedSegments = deleteLogStartOffsetBreachedSegments() +
deleteRetentionSizeBreachedSegments() +
deleteRetentionMsBreachedSegments();
} else if (config().compact) {
- return deleteLogStartOffsetBreachedSegments();
+ deletedSegments = deleteLogStartOffsetBreachedSegments();
} else {
// If cleanup.policy is empty and remote storage is enabled, the
local log segments will
// be cleaned based on the values of log.local.retention.bytes and
log.local.retention.ms
if (remoteLogEnabledAndRemoteCopyEnabled()) {
- return deleteLogStartOffsetBreachedSegments() +
+ deletedSegments = deleteLogStartOffsetBreachedSegments() +
deleteRetentionSizeBreachedSegments() +
deleteRetentionMsBreachedSegments();
} else {
// If cleanup.policy is empty and remote storage is disabled,
we should not delete any local log segments
// unless the log start offset advances through deleteRecords
- return deleteLogStartOffsetBreachedSegments();
+ deletedSegments = deleteLogStartOffsetBreachedSegments();
}
}
+ // To save CPU cycles, calculate retentionSizeInPercent only when the
log-cleaner thread runs
+ retentionSizeInPercentValue.set(calculateRetentionSizeInPercent());
Review Comment:
makes sense, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
