UladzislauBlok commented on code in PR #21567:
URL: https://github.com/apache/kafka/pull/21567#discussion_r2848838746
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java:
##########
@@ -35,7 +35,7 @@ public class ChangeLoggingSessionBytesStore
extends WrappedStateStore<SessionStore<Bytes, byte[]>, byte[], byte[]>
implements SessionStore<Bytes, byte[]> {
- private InternalProcessorContext<?, ?> internalContext;
+ InternalProcessorContext<?, ?> internalContext;
Review Comment:
I see why you made it package-private (to use it in child class), but from
my perspective package-private Implies two things:
- It's used withing package
- It's visible for testing
For currently case `protected` would be more natural
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
