lucliu1108 commented on PR #21557:
URL: https://github.com/apache/kafka/pull/21557#issuecomment-3953272416
Thanks for the review!
@squah-confluent @lucasbru I notice there's also change need in
`AssignorBenchmarkUtils#createGroupSpec` method. In this PR since we are still
keeping the same data structure for `assignedPartitions` for both
`SharedGroupMember` and `ConsumerGroupMember`, instance-wise conversion could
work. However, later on when the `ConsumerGroupMember#assignedPartition` is
modified to include epochs, the current fix won't work.
Considering that `createGroupSpec` is only used for empty member now, does
it make sense to simply pass in an empty assignment in this case?
```
memberSpecs.put(memberId, new MemberSubscriptionAndAssignmentImpl(
Optional.ofNullable(member.rackId()),
Optional.ofNullable(member.instanceId()),
new TopicIds(member.subscribedTopicNames(), topicResolver),
new Assignment(Assignment.EMPTY)
));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
