mimaison commented on code in PR #21523:
URL: https://github.com/apache/kafka/pull/21523#discussion_r2847884652
##########
server/src/test/java/org/apache/kafka/server/CordonedLogDirsIntegrationTest.java:
##########
@@ -223,30 +228,119 @@ public void testReassignWithCordonedLogDirs() throws
Exception {
assertInstanceOf(InvalidReplicaAssignmentException.class,
ee.getCause());
// After uncordoning the log dir, we can move the replica on it
- setCordonedLogDirs(admin, List.of());
+ setCordonedLogDirs(admin, List.of(), BROKER_0);
admin.alterReplicaLogDirs(Map.of(replica,
otherLogDir)).all().get();
}
}
- private Map<ConfigResource, Collection<AlterConfigOp>>
cordonedDirsConfig(String value) {
+ @ClusterTest(
+ brokers = 2,
+ controllers = 1
+ )
+ public void testDecommissionBroker() throws ExecutionException,
InterruptedException {
Review Comment:
Unfortunately adding a test for decommissioning log directories is tricky to
do with `ClusterTest` because we need to reconfigure the broker.
Maybe we should address that in a follow up PR? If so let's create a Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
