mjsax commented on code in PR #21455:
URL: https://github.com/apache/kafka/pull/21455#discussion_r2844083527
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreWithHeaders.java:
##########
@@ -102,12 +102,12 @@ public ValueTimestampHeaders<V> putIfAbsent(final K key,
public <R> QueryResult<R> query(final Query<R> query,
final PositionBound positionBound,
final QueryConfig config) {
- throw new UnsupportedOperationException("Querying is not supported for
" + getClass().getSimpleName());
+ throw new UnsupportedOperationException("Querying (IQv2) is not
supported for this store.");
}
@Override
public Position getPosition() {
- throw new UnsupportedOperationException("Position is not supported for
" + getClass().getSimpleName());
+ throw new UnsupportedOperationException("Position is not supported for
this store.");
Review Comment:
```suggestion
throw new UnsupportedOperationException("Queries (IQv2) are not
supported for timestamped key-value stores with headers yet.");
```
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreWithHeaders.java:
##########
@@ -102,12 +102,12 @@ public ValueTimestampHeaders<V> putIfAbsent(final K key,
public <R> QueryResult<R> query(final Query<R> query,
final PositionBound positionBound,
final QueryConfig config) {
- throw new UnsupportedOperationException("Querying is not supported for
" + getClass().getSimpleName());
+ throw new UnsupportedOperationException("Querying (IQv2) is not
supported for this store.");
Review Comment:
```suggestion
throw new UnsupportedOperationException("Queries (IQv2) are not
supported for timestamped key-value stores with headers yet.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
