omkreddy commented on PR #21452:
URL: https://github.com/apache/kafka/pull/21452#issuecomment-3943544053
I’ve noticed that Jetty 12 actually depends on slf4j-api 2.x. Ideally, we
shouldn’t upgrade Jetty unless we also upgrade slf4j-api (even on trunk).
We likely haven’t observed issues so far because there were no breaking
usages up to Jetty 12.0.29?. However, during testing with Jetty 12.0.32 and
slf4j-api 1.7.36, I observed the following error when debug logs were enabled:
```
java.lang.NoSuchMethodError: 'org.slf4j.spi.LoggingEventBuilder
org.slf4j.Logger.atDebug()'
at
org.eclipse.jetty.server.internal.HttpChannelState$ChannelCallback.completeChannelCallback(HttpChannelState.java:1588)
at
org.eclipse.jetty.server.internal.HttpChannelState$ChannelCallback.succeeded(HttpChannelState.java:1531)
at
org.eclipse.jetty.ee10.servlet.ServletChannel.onCompleted(ServletChannel.java:763)
at
org.eclipse.jetty.ee10.servlet.ServletChannel.handle(ServletChannel.java:428)
at
org.eclipse.jetty.ee10.servlet.ServletHandler.handle(ServletHandler.java:470)
at
org.eclipse.jetty.ee10.servlet.SessionHandler.handle(SessionHandler.java:717)
```
So upgrading Jetty without also upgrading slf4j-api can lead to runtime
failures?
cc @chia7712 @viktorsomogyi @AndrewJSchofield
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
