aliehsaeedii commented on code in PR #21512: URL: https://github.com/apache/kafka/pull/21512#discussion_r2827345885
########## streams/src/main/java/org/apache/kafka/streams/state/ReadOnlySessionStoreWithHeaders.java: ########## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state; + +import org.apache.kafka.streams.kstream.Windowed; + +import java.time.Instant; + +/** + * A session store that supports storing record headers and only supports read operations. + * Implementations should be thread-safe as concurrent reads and writes are expected. + * + * @param <K> the key type + * @param <AGG> the aggregated value type + */ +public interface ReadOnlySessionStoreWithHeaders<K, AGG> { Review Comment: I 'm not sure if it is possible to that `SessionStoreWithHeaders` extends `ReadOnlySessionStore` and we get rid of `ReadOnlySessionStoreWithHeaders`? This implies that AGG in `ReadOnlySessionStore` get casted to `AggregationWithHeaders<AGG>` when needed. Wondering whether it is possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
