lianetm commented on PR #21495: URL: https://github.com/apache/kafka/pull/21495#issuecomment-3920501786
> In SharePollEvent, we call > > requestManagers.consumerMembershipManager.ifPresent(consumerMembershipManager -> > consumerMembershipManager.maybeReconcile(true)); > This doesn't seem right. Why do we use a consumer membership manager for share poll events? That seems to be a no-op. > > It probably didn't matter much until now, but it would seem to me with this change we never call maybeReconcile(true)? > > cc @AndrewJSchofield Agree this seems off, looking back seems like the ShareConsumer poll always reused the same logic as the KafkaConsumer poll (same PollEvent initially, then split, but always relying on a consumerMmeberhipMgr to maybeReconcile from there, so no-op) This effectively means that the share consumer has always been reconciling only triggered from the background, which is not harmful for commit or have callbacks (share does not have them), but it lead to this same gap: assignments potentially updated without a triggering call to shareConsumer.poll. Makes sense? @AndrewJSchofield. I can fix it here, just checking I'm not missing anything -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
