lianetm commented on PR #21424: URL: https://github.com/apache/kafka/pull/21424#issuecomment-3910349948
Yeap, this is the same in both consumers (consumer pro-actively triggers callbacks to release assignment first, then sends leave request), so no commit in the pic (auto-commit on revocation only happens on reconciliations, when the revocation is triggered by the GC) That being said, seems we could improve this and provide the commit guarantee I imagine (just like we ensure commit before revocation triggered by the GC). Not to push it in this PR, but to think about it, we would have to review the contract of unsubscribe and auto-commit, the app expectations, consider error handling on unsubscribe (it doesn't throw much at the moment, letting the user unsubscribe regardless of errors like auth related, etc.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
