mjsax commented on code in PR #21454:
URL: https://github.com/apache/kafka/pull/21454#discussion_r2801517727


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalProcessorContext.java:
##########
@@ -122,6 +123,13 @@ void logChange(final String storeName,
                    final long timestamp,
                    final Position position);
 
+    void logChange(final String storeName,

Review Comment:
   This doesn't make a difference. Internally in the producer, both `null` and 
empty headers are the same thing: 
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java#L291



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to