mimaison commented on code in PR #21450:
URL: https://github.com/apache/kafka/pull/21450#discussion_r2797600976
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -199,7 +199,7 @@ public static Set<String> configNames() {
*/
public static void validateNames(Properties props) {
Review Comment:
If we want to do that change let's do it in a separate PR. The caller path
comes all the way from `ControllerConfigurationValidator` which uses
`Properties` for all resource types.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1289,8 +1289,8 @@ private void convertToClassicGroup(
metadataImage
);
} catch (SchemaException e) {
- log.warn("Cannot downgrade the consumer group " +
consumerGroup.groupId() + ": fail to parse " +
- "the Consumer Protocol " + ConsumerProtocol.PROTOCOL_TYPE +
".", e);
+ log.warn("Cannot downgrade the consumer group {}: fail to parse
the Consumer Protocol {}.",
+ consumerGroup.groupId(), ConsumerProtocol.PROTOCOL_TYPE,
e);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
