mjsax commented on code in PR #20955:
URL: https://github.com/apache/kafka/pull/20955#discussion_r2789772079
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -951,7 +952,8 @@ public long approximateNumEntries(final DBAccessor
accessor) throws RocksDBExcep
}
@Override
- public void flush(final DBAccessor accessor) throws RocksDBException {
+ public void commit(final DBAccessor accessor,
+ final Map<TopicPartition, Long> changelogOffsets)
throws RocksDBException {
accessor.flush(columnFamily);
Review Comment:
Wondering why this `flush(columnFamily)` call is not updated to
`commit(changelogOffsets)` or similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
