mingyen066 commented on code in PR #21439:
URL: https://github.com/apache/kafka/pull/21439#discussion_r2785543423
##########
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##########
@@ -355,7 +354,7 @@ object DumpLogSegments {
val voters = ControlRecordUtils.deserializeVotersRecord(record)
print(s" KRaftVoters ${VotersRecordJsonConverter.write(voters,
voters.version())}")
case controlType =>
- print(s" controlType: $controlType($controlTypeId)")
+ print(s" controlType: $controlType")
Review Comment:
Since `parseTypeId` is now private and callers use `parse()` instead,
`DumpLogSegments.printControlRecord` and
`MemoryRecordsBuilder.appendControlRecordWithOffset` no longer have access to
the raw `typeId`. This means the numeric
`typeId` is no longer included in the output/exception message (e.g.,
`UNKNOWN(337)` becomes `UNKNOWN`). Would it be acceptable to lose this debug
info, or should we keep `parseTypeId` accessible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
