nicktelford commented on code in PR #20954:
URL: https://github.com/apache/kafka/pull/20954#discussion_r2775562991
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java:
##########
@@ -596,6 +639,7 @@ private void cleanRemovedTasksCalledByCleanerThread(final
long cleanupDelayMs) {
final long now = time.milliseconds();
final long lastModifiedMs =
taskDir.file().lastModified();
if (now - cleanupDelayMs > lastModifiedMs) {
+ removeTaskOffsets(id);
Review Comment:
I don't follow I'm afraid. Can you elaborate?
`taskOffsetSums.clear()` is in `close()`, but this `removeTaskOffsets(id)`
is in `cleanRemovedTasksCalledByCleanerThread()`, which isn't called by
`close()` or vice-versa?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
