ezhou413 commented on code in PR #21308: URL: https://github.com/apache/kafka/pull/21308#discussion_r2757161845
########## config/streams.properties: ########## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +############################# Kafka Streams Configuration ############################# + +# A unique name for the Kafka Streams application. +# Used as consumer group id and for internal state topics. +# REQUIRED (no default) +application.id=my-streams-app + +# Comma-separated list of Kafka brokers. +# REQUIRED (no default) +bootstrap.servers=<localhost:9092> +############################# Stream Threads ############################# + +# Number of stream processing threads. +# Default: 1 +num.stream.threads=1 +############################# Default SerDes ############################# Review Comment: Serdes do not have default values. Could you comment this section out, and list possible values for these configs? ########## config/streams.properties: ########## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +############################# Kafka Streams Configuration ############################# + +# A unique name for the Kafka Streams application. +# Used as consumer group id and for internal state topics. +# REQUIRED (no default) +application.id=my-streams-app + +# Comma-separated list of Kafka brokers. +# REQUIRED (no default) +bootstrap.servers=<localhost:9092> Review Comment: Could you remove the `<>` brackets? ########## config/streams.properties: ########## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +############################# Kafka Streams Configuration ############################# + +# A unique name for the Kafka Streams application. +# Used as consumer group id and for internal state topics. +# REQUIRED (no default) +application.id=my-streams-app + +# Comma-separated list of Kafka brokers. +# REQUIRED (no default) +bootstrap.servers=<localhost:9092> +############################# Stream Threads ############################# + +# Number of stream processing threads. +# Default: 1 +num.stream.threads=1 +############################# Default SerDes ############################# + +# Default key serializer/deserializer. +# Default: org.apache.kafka.common.serialization.ByteArraySerde +default.key.serde=org.apache.kafka.common.serialization.StringSerde + +# Default value serializer/deserializer. +# Default: org.apache.kafka.common.serialization.ByteArraySerde +default.value.serde=org.apache.kafka.common.serialization.StringSerde +############################# Processing Guarantees ############################# + +# Processing guarantee. +# Values: at_least_once, exactly_once_v2 +# Default: at_least_once +processing.guarantee=at_least_once + +# Commit interval for state and offsets (ms). +# Default: 30000 +commit.interval.ms=30000 +############################# State Store ############################# + +# Directory for local state stores. +# Default: /tmp/kafka-streams +state.dir=/tmp/kafka-streams + +# Maximum number of standby replicas. +# Default: 0 +num.standby.replicas=0 +############################# Caching ############################# + +# Maximum memory used for buffering records (bytes). +# Default: 10485760 (10 MB) +cache.max.bytes.buffering=10485760 +############################# Internal Topics ############################# + +# Replication factor for internal topics (changelog, repartition). +# Default: -1 (uses broker default) +replication.factor=-1 +############################# Topology Optimization ############################# + +# Enable topology optimization. +# Values: none, all +# Default: none +topology.optimization=none Review Comment: Please list the possible values for this in the comments above ########## config/streams.properties: ########## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +############################# Kafka Streams Configuration ############################# + +# A unique name for the Kafka Streams application. +# Used as consumer group id and for internal state topics. +# REQUIRED (no default) +application.id=my-streams-app + +# Comma-separated list of Kafka brokers. +# REQUIRED (no default) +bootstrap.servers=<localhost:9092> +############################# Stream Threads ############################# + +# Number of stream processing threads. +# Default: 1 +num.stream.threads=1 +############################# Default SerDes ############################# + +# Default key serializer/deserializer. +# Default: org.apache.kafka.common.serialization.ByteArraySerde +default.key.serde=org.apache.kafka.common.serialization.StringSerde + +# Default value serializer/deserializer. +# Default: org.apache.kafka.common.serialization.ByteArraySerde +default.value.serde=org.apache.kafka.common.serialization.StringSerde +############################# Processing Guarantees ############################# + +# Processing guarantee. +# Values: at_least_once, exactly_once_v2 +# Default: at_least_once +processing.guarantee=at_least_once + +# Commit interval for state and offsets (ms). +# Default: 30000 +commit.interval.ms=30000 Review Comment: The documentation for this config specifies different defaults depending on the configured `processing.guarantee`. Could you mention this in the comments above the config? https://github.com/apache/kafka/blob/5498eedf92a016e6838bce5383042bda1c798d76/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java#L475-L478 ########## config/streams.properties: ########## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +############################# Kafka Streams Configuration ############################# + +# A unique name for the Kafka Streams application. +# Used as consumer group id and for internal state topics. +# REQUIRED (no default) +application.id=my-streams-app + +# Comma-separated list of Kafka brokers. +# REQUIRED (no default) +bootstrap.servers=<localhost:9092> +############################# Stream Threads ############################# + +# Number of stream processing threads. +# Default: 1 +num.stream.threads=1 +############################# Default SerDes ############################# + +# Default key serializer/deserializer. +# Default: org.apache.kafka.common.serialization.ByteArraySerde +default.key.serde=org.apache.kafka.common.serialization.StringSerde + +# Default value serializer/deserializer. +# Default: org.apache.kafka.common.serialization.ByteArraySerde +default.value.serde=org.apache.kafka.common.serialization.StringSerde +############################# Processing Guarantees ############################# + +# Processing guarantee. +# Values: at_least_once, exactly_once_v2 +# Default: at_least_once +processing.guarantee=at_least_once + +# Commit interval for state and offsets (ms). +# Default: 30000 +commit.interval.ms=30000 +############################# State Store ############################# + +# Directory for local state stores. +# Default: /tmp/kafka-streams +state.dir=/tmp/kafka-streams + +# Maximum number of standby replicas. +# Default: 0 +num.standby.replicas=0 +############################# Caching ############################# + +# Maximum memory used for buffering records (bytes). +# Default: 10485760 (10 MB) +cache.max.bytes.buffering=10485760 Review Comment: This property has been deprecated since 3.4: https://github.com/apache/kafka/blob/5498eedf92a016e6838bce5383042bda1c798d76/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java#L458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
