squah-confluent commented on PR #21313:
URL: https://github.com/apache/kafka/pull/21313#issuecomment-3811776287
The code change is fine by me.
The current documentation change raises some questions. It would be nice to
improve the wording.
* When do clients generate UUIDs? There are member IDs but I believe that is
a recommendation / convention that we use rather than a requirement.
[KIP-1082](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1082%3A+Require+Client-Generated+IDs+over+the+ConsumerGroupHeartbeat+RPC)
says
> In the new version of the ConsumerGroupHeartbeat RPC, the client must
generate a UUID as the member ID during the initial heartbeat. This member ID
must be included in every subsequent request to ensure consistency. We highly
recommend that users utilize a UUID as the member ID, but ultimately, the
choice is up to the user."
It's contradictory but it sounds like it's trying to say that member IDs
can be any format but the recommendation is a base64-encoded UUID.
* To the average developer, a UUID looks like
"00000000-0000-0000-0000-000000000000". It's not clear that we are referring to
the base64-encoded form, and not even the "default" encoding with "+" and "/",
but the URL-safe encoding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
