mimaison commented on code in PR #21302: URL: https://github.com/apache/kafka/pull/21302#discussion_r2732410158
########## server/src/main/java/org/apache/kafka/server/config/DynamicConfig.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.config; + +import org.apache.kafka.common.config.ConfigDef; + +import java.util.HashSet; +import java.util.Map; +import java.util.Properties; +import java.util.Set; + +/** + * Class used to hold dynamic configs. These are configs which have no physical manifestation in the server.properties + * and can only be set dynamically. + */ +public class DynamicConfig { + + public static class Broker { + + private static final ConfigDef BROKER_CONFIGS; + static { + ConfigDef configs = QuotaConfig.brokerQuotaConfigs(); + // Filter and define all dynamic configurations + AbstractKafkaConfig.CONFIG_DEF.configKeys().forEach((name, value) -> { + if (DynamicBrokerConfig.ALL_DYNAMIC_CONFIGS.contains(name)) { + configs.define(value); + } + }); + BROKER_CONFIGS = configs; + } + + // In order to avoid circular reference, all DynamicBrokerConfig's variables which are initialized by `DynamicConfig.Broker` should be moved to `DynamicConfig.Broker`. Review Comment: I've updated the comment. I'm kind of leaning towards keeping the static method, at least for now. Having all these static variables in various files depending on each other is kind of messy. I guess your point of merging some of these classes was to resolve some of this. I don't know quite know which way to go right now. As I said above these files are large so I'd really like to split them into smaller chunks if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
