m1a2st commented on code in PR #21343:
URL: https://github.com/apache/kafka/pull/21343#discussion_r2721020357
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java:
##########
@@ -689,7 +689,7 @@ private static long maxCompactionDelay(UnifiedLog log, long
firstDirtyOffset, lo
* @return OffsetsToClean containing offsets for cleanable portion of log
and whether the log checkpoint needs updating
* @throws IOException if an I/O error occurs
*/
- public static OffsetsToClean cleanableOffsets(UnifiedLog log,
Optional<Long> lastCleanOffset, long now) throws IOException {
Review Comment:
Could you also add comment `Visible for testing`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
