adixitconfluent commented on code in PR #20765:
URL: https://github.com/apache/kafka/pull/20765#discussion_r2468070012
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -2149,12 +2169,10 @@ static void
mockTopicIdPartitionToReturnDataEqualToMinBytes(ReplicaManager repli
when(replicaManager.getPartitionOrException(topicIdPartition.topicPartition())).thenReturn(partition);
}
- private void mockTopicIdPartitionFetchBytes(ReplicaManager replicaManager,
TopicIdPartition topicIdPartition, LogOffsetMetadata hwmOffsetMetadata) {
+ private void mockTopicIdPartitionFetchBytes(LogOffsetMetadata
hwmOffsetMetadata, Partition partition) {
LogOffsetSnapshot endOffsetSnapshot = new LogOffsetSnapshot(1,
mock(LogOffsetMetadata.class),
- hwmOffsetMetadata, mock(LogOffsetMetadata.class));
- Partition partition = mock(Partition.class);
+ hwmOffsetMetadata, mock(LogOffsetMetadata.class));
Review Comment:
nit: Indentation (extra spaces)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
