lucasbru commented on code in PR #20777:
URL: https://github.com/apache/kafka/pull/20777#discussion_r2463852548
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -3769,37 +3593,6 @@ public void shouldCommitViaConsumerIfEosDisabled() {
verify(consumer).commitSync(offsets);
}
- @SuppressWarnings("removal")
- @Test
- public void shouldCommitViaProducerIfEosV2Enabled() {
Review Comment:
Why are you removing this without replacement?
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -2839,75 +2732,6 @@ public void shouldSuspendActiveTasksDuringRevocation() {
assertThat(task00.state(), is(Task.State.SUSPENDED));
}
- @SuppressWarnings("removal")
- @Test
- public void
shouldCommitAllActiveTasksThatNeedCommittingOnHandleRevocationWithEosV2() {
Review Comment:
Why are you removing this without replacement?
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -2839,75 +2732,6 @@ public void shouldSuspendActiveTasksDuringRevocation() {
assertThat(task00.state(), is(Task.State.SUSPENDED));
}
- @SuppressWarnings("removal")
- @Test
- public void
shouldCommitAllActiveTasksThatNeedCommittingOnHandleRevocationWithEosV2() {
Review Comment:
Why are you removing this without replacement?
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -2839,75 +2732,6 @@ public void shouldSuspendActiveTasksDuringRevocation() {
assertThat(task00.state(), is(Task.State.SUSPENDED));
}
- @SuppressWarnings("removal")
- @Test
- public void
shouldCommitAllActiveTasksThatNeedCommittingOnHandleRevocationWithEosV2() {
Review Comment:
Why are you removing this without replacement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
