shashankhs11 commented on code in PR #20285:
URL: https://github.com/apache/kafka/pull/20285#discussion_r2424322306
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/ProduceRequestResult.java:
##########
@@ -129,6 +148,17 @@ public TopicPartition topicPartition() {
* Has the request completed?
*/
public boolean completed() {
- return this.latch.getCount() == 0L;
+ if (this.latch.getCount() != 0L) {
+ return false;
+ }
+ // are all the dependent results completed?
+ synchronized (dependentResults) {
Review Comment:
Understood! Thank you so much for the detailed explanation, jun. I've made
the suggested changes in e0d67a3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
