lucasbru commented on code in PR #20681:
URL: https://github.com/apache/kafka/pull/20681#discussion_r2419968197
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroupMember.java:
##########
@@ -284,13 +295,16 @@ public static Builder withDefaults(String memberId) {
.setTopologyEpoch(-1)
.setInstanceId(null)
.setRackId(null)
+ .setClientId("")
Review Comment:
Minor clean-up on the side. `withDefaults` sets all fields except for
`client-id` and `client-host`. These are initialized to "" in
`ConsumerGroupMember`. In production code this does not make a difference,
since we always update client-id and client-host with information received from
the heartbeat. I just found it confusing that all but 2 fields are initialized
with defaults here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
