chia7712 commented on code in PR #20612:
URL: https://github.com/apache/kafka/pull/20612#discussion_r2393881606
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginUtils.java:
##########
@@ -209,7 +209,7 @@ public static Set<Path> pluginLocations(String pluginPath,
boolean failFast) {
for (String path : pluginPathElements) {
try {
Path pluginPathElement = Paths.get(path).toAbsolutePath();
- if (pluginPath.isEmpty()) {
+ if (path.isEmpty()) {
Review Comment:
Is this a bug fix?
##########
tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java:
##########
@@ -171,7 +171,7 @@ private static Set<Path> parseLocations(ArgumentParser
parser, Namespace namespa
throw new TerseException("Unable to read worker config at " +
rawWorkerConfig);
}
String pluginPath =
properties.getProperty(WorkerConfig.PLUGIN_PATH_CONFIG);
- if (pluginPath != null) {
+ if (pluginPath != null && !pluginPath.isEmpty()) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
