chia7712 commented on code in PR #20492:
URL: https://github.com/apache/kafka/pull/20492#discussion_r2380730725
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1658,7 +1658,7 @@ class Partition(val topicPartition: TopicPartition,
def deleteRecordsOnLeader(offset: Long): LogDeleteRecordsResult =
inReadLock(leaderIsrUpdateLock) {
leaderLogIfLocal match {
case Some(leaderLog) =>
- if (!leaderLog.config.delete)
+ if (!leaderLog.config.delete && leaderLog.config.compact)
Review Comment:
@m1a2st please update KIP and upgrade.html to match this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
