chia7712 commented on code in PR #20325:
URL: https://github.com/apache/kafka/pull/20325#discussion_r2379548348
##########
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala:
##########
@@ -264,4 +349,101 @@ class DefaultAutoTopicCreationManager(
(creatableTopics, uncreatableTopics)
}
+
+ private def sendCreateTopicRequestWithErrorCaching(
+ creatableTopics: Map[String, CreatableTopic],
+ requestContext: Option[RequestContext],
Review Comment:
Excuse me, it seems there is no case where `none` is passed to
`requestContext`. Is it intended to support more use case in the future? If
not, removing the `Option` could simplify the code introduced in #20569
##########
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala:
##########
@@ -264,4 +349,101 @@ class DefaultAutoTopicCreationManager(
(creatableTopics, uncreatableTopics)
}
+
+ private def sendCreateTopicRequestWithErrorCaching(
+ creatableTopics: Map[String, CreatableTopic],
+ requestContext: Option[RequestContext],
Review Comment:
Excuse me, it seems there is no case where `none` is passed to
`requestContext`. Is it intended to support more use case in the future? If
not, removing the `Option` could simplify the code introduced in #20569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
