chia7712 commented on code in PR #19914:
URL: https://github.com/apache/kafka/pull/19914#discussion_r2366227345
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -1494,6 +1494,27 @@ private static void
assertEmptyPendingRequests(CommitRequestManager commitReques
assertTrue(commitRequestManager.pendingRequests.unsentOffsetCommits.isEmpty());
}
+ @Test
+ public void testPollWithFatalErrorDuringCoordinatorIsEmptyAndClosing() {
Review Comment:
This unit test only covers the path of
`coordinatorRequestManager.coordinator().isEmpty() ->
pendingRequests.maybeFailOnCoordinatorFatalError`. Could you please add another
one to cover the case of `closing && pendingRequests.hasUnsentRequests()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
