dongnuo123 commented on code in PR #20417:
URL: https://github.com/apache/kafka/pull/20417#discussion_r2364431920
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2466,31 +2476,30 @@ private CoordinatorResult<Void, CoordinatorRecord>
classicGroupJoinToConsumerGro
} else {
targetAssignmentEpoch = group.assignmentEpoch();
targetAssignment =
group.targetAssignment(updatedMember.memberId(), updatedMember.instanceId());
-
}
- // 3. Reconcile the member's assignment with the target assignment if
the member is not
- // fully reconciled yet.
- updatedMember = maybeReconcile(
- groupId,
- updatedMember,
- group::currentPartitionEpoch,
- targetAssignmentEpoch,
- targetAssignment,
- toTopicPartitions(subscription.ownedPartitions(), metadataImage),
- records
- );
+ // 3. If it's not a downgrade triggered by static member replacement
with a different subscription,
+ // reconcile the member's assignment with the target assignment if the
member is not fully reconciled yet.
+ if (!bumpGroupEpoch || !downgrade) {
Review Comment:
We only skip the reconciliation if (bumpGroupEpoch && downgrade). So if the
group epoch has not changed, we will try reconciling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
