chia7712 commented on code in PR #20504:
URL: https://github.com/apache/kafka/pull/20504#discussion_r2362470876
##########
shell/src/main/java/org/apache/kafka/shell/command/FindCommandHandler.java:
##########
@@ -112,8 +112,9 @@ private void find(PrintWriter writer, String path,
MetadataNode node) {
String nextPath = path.equals("/") ? path + name : path + "/"
+ name;
MetadataNode child = node.child(name);
if (child == null) {
- throw new RuntimeException("Expected " + name + " to be a
valid child of " +
+ writer.println("Expected " + name + " to be a valid child
of " +
Review Comment:
We don't really need this change since dropping `ZK_MIGRATION_STATE` alone
should be sufficient
##########
metadata/src/main/java/org/apache/kafka/image/node/FeaturesImageNode.java:
##########
@@ -57,7 +57,6 @@ public FeaturesImageNode(FeaturesImage image) {
public Collection<String> childNames() {
ArrayList<String> childNames = new ArrayList<>();
childNames.add(METADATA_VERSION);
- childNames.add(ZK_MIGRATION_STATE);
Review Comment:
Please also remove `ZK_MIGRATION_STATE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
