lucasbru commented on code in PR #20511:
URL: https://github.com/apache/kafka/pull/20511#discussion_r2349332471
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1527,26 +1495,39 @@ private void autoCommitOnClose(final Timer timer) {
}
private void runRebalanceCallbacksOnClose() {
- if (groupMetadata.get().isEmpty() || rebalanceListenerInvoker == null)
+ if (groupMetadata.get().isEmpty())
return;
int memberEpoch = groupMetadata.get().get().generationId();
- Set<TopicPartition> assignedPartitions = groupAssignmentSnapshot.get();
+ final Exception error;
- if (assignedPartitions.isEmpty())
- // Nothing to revoke.
- return;
+ if (streamsRebalanceListenerInvoker.isPresent()) {
Review Comment:
Wow, that close is sneaky. Fixed.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1527,26 +1495,39 @@ private void autoCommitOnClose(final Timer timer) {
}
private void runRebalanceCallbacksOnClose() {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
