m1a2st commented on code in PR #20524:
URL: https://github.com/apache/kafka/pull/20524#discussion_r2343067601
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##########
@@ -195,6 +195,20 @@ public void testAsyncConsumerHeaders() throws Exception {
));
}
+ @ClusterTest
+ public void testClassicConsumerHeadersOrderPreserved() throws Exception {
+ testHeadersOrderPreserved(Map.of(
+ GROUP_PROTOCOL_CONFIG,
GroupProtocol.CLASSIC.name().toLowerCase(Locale.ROOT)
+ ));
+ }
+
+ @ClusterTest
+ public void testAsyncConsumerHeadersOrderPreserved() throws Exception {
+ testHeadersOrderPreserved(Map.of(
+ GROUP_PROTOCOL_CONFIG,
GroupProtocol.CONSUMER.name().toLowerCase(Locale.ROOT)
+ ));
+ }
Review Comment:
Could you move `testClassicConsumerHeadersOrderPreserved` and
`testAsyncConsumerHeadersOrderPreserved` methods under the `testHeaders` test
and group the related ones together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
