mimaison commented on code in PR #20468: URL: https://github.com/apache/kafka/pull/20468#discussion_r2337267974
########## metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.metadata.publisher; + +import org.apache.kafka.image.MetadataDelta; +import org.apache.kafka.image.MetadataImage; +import org.apache.kafka.image.ScramDelta; +import org.apache.kafka.image.loader.LoaderManifest; +import org.apache.kafka.image.publisher.MetadataPublisher; +import org.apache.kafka.security.CredentialProvider; +import org.apache.kafka.server.fault.FaultHandler; + +public class ScramPublisher implements MetadataPublisher { + private final int nodeId; + private final FaultHandler faultHandler; + private final String nodeType; + private final CredentialProvider credentialProvider; + + public ScramPublisher(int nodeId, FaultHandler faultHandler, String nodeType, CredentialProvider credentialProvider) { + this.nodeId = nodeId; + this.faultHandler = faultHandler; + this.nodeType = nodeType; + this.credentialProvider = credentialProvider; + } + + @Override + public final String name() { + return "ScramPublisher " + nodeType + " id=" + nodeId; + } + + @Override + public void onMetadataUpdate(MetadataDelta delta, MetadataImage newImage, LoaderManifest manifest) { + onMetadataUpdate(delta, newImage); + } + + public void onMetadataUpdate(MetadataDelta delta, MetadataImage newImage) { + String deltaName = "MetadataDelta up to " + newImage.highestOffsetAndEpoch().offset(); Review Comment: My point was consistency. Maybe there's an explanation but looking at these classes they all catch `Throwable` and run `faultHandler.handleFault()` apart from `FeaturesPublisher` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
