chia7712 commented on code in PR #20380:
URL: https://github.com/apache/kafka/pull/20380#discussion_r2342475221
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##########
@@ -303,8 +303,8 @@ public void reset() throws IOException {
}
/**
- * Get offset relative to base offset of this index
- * @throws IndexOffsetOverflowException
+ * Gets the offset relative to the base offset of this index.
+ * @throws IndexOffsetOverflowException if relativeOffset (of type
OptionalInt) is empty
Review Comment:
Perhaps the comment should focus on the input `offset`. For example, it
would be helpful to explain why the input `offset` is considered invalid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
