MahsaSeifikar commented on code in PR #20422:
URL: https://github.com/apache/kafka/pull/20422#discussion_r2337991947
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -532,6 +532,7 @@ private void handleEventEnd(String name, long
startProcessingTimeNs) {
MICROSECONDS.convert(deltaNs, NANOSECONDS));
performanceMonitor.observeEvent(name, deltaNs);
controllerMetrics.updateEventQueueProcessingTime(NANOSECONDS.toMillis(deltaNs));
+ controllerMetrics.updateIdleStartTime();
Review Comment:
I implemented it this way because most controller-related metrics are within
`QuorumController` and I wanted to follow the same pattern. In the initial
implementation, we measured the idle time between start and end events, as well
as the time spent waiting for deffered events to be completed, without
modifying `KafkaEventQueue`. However, your feedback makes sense to me, and
I’ve updated the implementation accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
