see-quick commented on code in PR #20468:
URL: https://github.com/apache/kafka/pull/20468#discussion_r2333800898
##########
metadata/src/main/java/org/apache/kafka/metadata/publisher/ScramPublisher.java:
##########
@@ -55,10 +56,11 @@ public void onMetadataUpdate(MetadataDelta delta,
MetadataImage newImage) {
if (scramDelta != null) {
scramDelta.changes().forEach((mechanism, userChanges) -> {
userChanges.forEach((userName, change) -> {
+ ScramMechanism internalMechanism =
ScramMechanism.forMechanismName(mechanism.mechanismName());
Review Comment:
ScramMechanism.forMechanismName returns
`org.apache.kafka.common.security.scram.internals.ScramMechanism` and
CredentialProvider methods, i.e., removeCredential and updateCredential need
`org.apache.kafka.common.security.scram.internals.ScramMechanism` type instead
of `
org.apache.kafka.clients.admin.ScramMechanism`.
`scramDelta.changes()` using
`org.apache.kafka.clients.admin.ScramMechanism`. That's why I have added that
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
