mimaison commented on PR #20359: URL: https://github.com/apache/kafka/pull/20359#issuecomment-3270065582
Thanks for the PR. The performance gains seem impressive! I don't think this method is called in particularly hot code paths. In addition reviewing this kind of code is tricky. This might explain why nobody really looked at this yet. Our implementation was based on the Apache commons codec: https://github.com/apache/commons-codec/blob/master/src/main/java/org/apache/commons/codec/digest/MurmurHash2.java#L79-L121. Do you have references on which you based your implementation on? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
