josefk31 commented on PR #20446: URL: https://github.com/apache/kafka/pull/20446#issuecomment-3266994013
> It seems the word `maxBatchSize` is still used in code case. Should we align them in this PR? @chia7712 do you mean it's still used [here](https://github.com/apache/kafka/blob/f7593db2878c7332ec8c37ef78ccd0bc704e4fcc/core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala#L161) (and a few other places)? If that is the case, on the one hand this is just a refactoring; on the other hand it's not an area of the code I'm familiar with. Not a huge deal to change - it seems like other usages are mostly local variables. IG it can't hurt. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
