[ 
https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018759#comment-18018759
 ] 

Ksolves India Limited commented on KAFKA-19097:
-----------------------------------------------

Hi [~mjsax] / [~lorcanj],

Can I pick this up?
I believe handling this entire ticket for Kafka at once would be lengthy and 
time-consuming.

My approach would be to create sub-tickets for each module and raise PRs on a 
daily/weekly basis. This way, we’ll have cleaner PRs, better module-wise 
tracking, and also the flexibility to prioritize which modules need to be 
refactored first.

Let me know your thoughts.

> Fix order of arguments to assertEquals
> --------------------------------------
>
>                 Key: KAFKA-19097
>                 URL: https://issues.apache.org/jira/browse/KAFKA-19097
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams, unit tests
>            Reporter: Lorcan
>            Assignee: HongYi Chen
>            Priority: Minor
>              Labels: beginner-friendly, newbie,
>
> There are examples of tests using assertEquals where the arguments are in the 
> wrong order.
> Example from InternalStreamsBuilderTest:
> assertEquals(count.get(), 3);
> The expected value should be the first argument.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to