shashankhs11 commented on code in PR #20501:
URL: https://github.com/apache/kafka/pull/20501#discussion_r2328920064
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -1911,14 +1876,14 @@ public void
shouldComputeOffsetSumForRestoringStandbyTaskWithStateUpdater() thro
}
@Test
- public void
shouldComputeOffsetSumForRunningStatefulTaskAndRestoringTaskWithStateUpdater() {
+ public void shouldComputeOffsetSumForRunningStatefulTaskAndRestoringTask()
{
final StreamTask runningStatefulTask = statefulTask(taskId00,
taskId00ChangelogPartitions)
.inState(State.RUNNING).build();
final StreamTask restoringStatefulTask = statefulTask(taskId01,
taskId01ChangelogPartitions)
.inState(State.RESTORING).build();
final StandbyTask restoringStandbyTask = standbyTask(taskId02,
taskId02ChangelogPartitions)
.inState(State.RUNNING).build();
- final long changelogOffsetOfRunningTask = 42L;
+ final long changelogOffsetOfRunningTask = Task.LATEST_OFFSET;
Review Comment:
as suggested in
https://github.com/apache/kafka/pull/19275#discussion_r2107814832
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -1943,14 +1908,26 @@ public void
shouldComputeOffsetSumForRunningStatefulTaskAndRestoringTaskWithStat
}
@Test
- public void shouldSkipUnknownOffsetsWhenComputingOffsetSum() throws
Exception {
Review Comment:
as suggested in
https://github.com/apache/kafka/pull/19275#discussion_r2107828813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
