[
https://issues.apache.org/jira/browse/KAFKA-19683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018691#comment-18018691
]
Shashank commented on KAFKA-19683:
----------------------------------
Hi [~lucasbru], since the tests in the cleanup of this file are many, I would
like to propose to make incremental changes to this cleanup.
- Removal of dead tests and address these 3 comments -
[#1|https://github.com/apache/kafka/pull/19275#discussion_r2107811068],
[#2|https://github.com/apache/kafka/pull/19275#discussion_r2107814832] and
[#3|https://github.com/apache/kafka/pull/19275#discussion_r2107828813] made in
the previous stale PR ([#19275|https://github.com/apache/kafka/pull/19275]).
- Identify and replace tryToCompleteRestoration() with checkStateUpdater() in
all tests that require no additional mocking
- Modify tests that may require to be rewritten (I still am doing my analysis
of this and may need some help)
Steps 1 and 2 seem to be straightforward and also I think splitting would make
it easier for you to review. Step 3 is where I may need some guidance and help.
Do you think this is a good approach?
> Clean up TaskManagerTest
> ------------------------
>
> Key: KAFKA-19683
> URL: https://issues.apache.org/jira/browse/KAFKA-19683
> Project: Kafka
> Issue Type: Sub-task
> Components: streams, unit tests
> Reporter: Shashank
> Assignee: Shashank
> Priority: Blocker
> Fix For: 4.2.0
>
>
> See https://github.com/apache/kafka/pull/20392#issuecomment-3241457533
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
