chia7712 commented on code in PR #20493:
URL: https://github.com/apache/kafka/pull/20493#discussion_r2327940711
##########
clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java:
##########
@@ -67,8 +68,11 @@ public static synchronized void registerAppInfo(String
prefix, String id, Metric
}
AppInfo mBean = new AppInfo(nowMs);
server.registerMBean(mBean, name);
-
- registerMetrics(metrics, mBean); // prefix will be added later by
JmxReporter
+
+ registerMetrics(metrics, mBean, null); // prefix will be added
later by JmxReporter
+ if (!metrics.config().tags().containsKey("client-id")) {
Review Comment:
`if (!metrics.config().tags().containsKey("client-id"))` may need to include
`clientId != null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
