Yunyung commented on code in PR #20385:
URL: https://github.com/apache/kafka/pull/20385#discussion_r2325500088
##########
tests/kafkatest/services/performance/consumer_performance.py:
##########
@@ -115,7 +115,7 @@ def start_cmd(self, node):
for key, value in self.args(node.version).items():
cmd += " --%s %s" % (key, value)
- cmd += " --consumer.config %s" % ConsumerPerformanceService.CONFIG_FILE
+ cmd += " --command-config %s" % ConsumerPerformanceService.CONFIG_FILE
Review Comment:
Will this break e2e testing with older broker versions? (See
https://github.com/apache/kafka/pull/20471)
##########
tests/kafkatest/services/performance/share_consumer_performance.py:
##########
@@ -100,7 +100,7 @@ def start_cmd(self, node):
for key, value in self.args().items():
cmd += " --%s %s" % (key, value)
- cmd += " --consumer.config %s" %
ShareConsumerPerformanceService.CONFIG_FILE
+ cmd += " --command-config %s" %
ShareConsumerPerformanceService.CONFIG_FILE
Review Comment:
Ditto. The shared consumer is still new, so maybe it’s not a big deal. I’m
not sure though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
