lucasbru commented on PR #20392: URL: https://github.com/apache/kafka/pull/20392#issuecomment-3241457533
Cleaning up integration tests sounds good. However, before starting to actually removing the production code path, I would suggest starting with the tricky bit, and then working your way to the easier parts. We don't want to remove half of the old code path first, to then realize that we cannot figure out how to preserve test coverage without the old code path. IIRC the "tricky bit" that @janchilling was stuck with is porting the tests that use `tryToCompleteRestoration` in `TaskManagerTest` to not use `tryToCompleteRestoration` (because it will be removed). I think, for the most part, the function is only used to advance task state, and it should be possible to replace it by using `checkStateUpdater` and mocking the `stateUpdater` mock correctly. We can also remove tests if we can point to an existing test that tests the equivalent state updater code path. Once we have solved this, the rest should just be removing code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
