kirktrue commented on PR #20324: URL: https://github.com/apache/kafka/pull/20324#issuecomment-3237712843
Thanks for the review @AndrewJSchofield! > Overall, I think my main observation about the PR is that it makes the class diagram even more peculiar than it was before. The classes know too much about each other really. Whether that's a future refactor or a refactor as part of this PR I am not sure. I wholeheartedly agree. Do you think that grouping all the shared state under `ThreadSafeConsumerState` (and its subclasses) is a good idea or bad? I'm struggling with wanting to keep the pieces loosely-coupled and wanting keep the "unsafe" bits together where the intention/hazards are more prominent. Any thoughts on this are welcome! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
