lucasbru commented on code in PR #19967:
URL: https://github.com/apache/kafka/pull/19967#discussion_r2307714058
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java:
##########
@@ -52,6 +54,10 @@ public void updateGroupConfig(String groupId, Properties
newGroupConfig) {
throw new InvalidRequestException("Group name can't be empty.");
}
+ if (groupConfigListener != null) {
+ groupConfigListener.onGroupConfigUpdate(groupId, newGroupConfig);
+ }
+
Review Comment:
Although I don't understand why this is timing related (the group epoch
would be bumped on every single restart, no?), I see this is a serious problem.
Even if there is a way around it, I am indeed now leaning towards storing the
configuration in the group metadata record. This indeed requires a KIP,
unfortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
