junrao commented on code in PR #20334:
URL: https://github.com/apache/kafka/pull/20334#discussion_r2302426453
##########
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##########
@@ -71,7 +71,11 @@ public class ServerLogConfigs {
public static final String LOG_CLEANUP_POLICY_CONFIG =
ServerTopicConfigSynonyms.serverSynonym(TopicConfig.CLEANUP_POLICY_CONFIG);
public static final String LOG_CLEANUP_POLICY_DEFAULT =
TopicConfig.CLEANUP_POLICY_DELETE;
- public static final String LOG_CLEANUP_POLICY_DOC = "The default cleanup
policy for segments beyond the retention window. A comma separated list of
valid policies.";
+ public static final String LOG_CLEANUP_POLICY_DOC = "The default cleanup
policy for segments beyond the retention window. " +
+ "A comma separated list of valid policies. The \"delete\" policy
will discard old segments when their " +
Review Comment:
Could we reuse TopicConfig.CLEANUP_POLICY_DOC?
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -79,7 +80,11 @@ public AbstractKafkaConfig(ConfigDef definition, Map<?, ?>
originals, Map<String
}
public List<String> logDirs() {
- return
Csv.parseCsvList(Optional.ofNullable(getString(ServerLogConfigs.LOG_DIRS_CONFIG)).orElse(getString(ServerLogConfigs.LOG_DIR_CONFIG)));
+ return Optional.ofNullable(getList(ServerLogConfigs.LOG_DIRS_CONFIG))
+
.orElse(Arrays.stream(getString(ServerLogConfigs.LOG_DIR_CONFIG).split(",")).toList())
Review Comment:
Has this change been reflected in the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
