lucasbru commented on code in PR #20288:
URL: https://github.com/apache/kafka/pull/20288#discussion_r2297665341
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -6066,7 +6075,7 @@ public CoordinatorResult<Void, CoordinatorRecord>
classicGroupJoin(
// classicGroupJoinToConsumerGroup takes the join requests to
non-empty consumer groups.
// The empty consumer groups should be converted to classic
groups in classicGroupJoinToClassicGroup.
return classicGroupJoinToConsumerGroup((ConsumerGroup) group,
context, request, responseFuture);
- } else if (group.type() == CONSUMER || group.type() == CLASSIC) {
+ } else if (group.type() == CONSUMER || group.type() == CLASSIC ||
group.type() == STREAMS && group.isEmpty()) {
return classicGroupJoinToClassicGroup(context, request,
responseFuture);
Review Comment:
Done
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -833,19 +833,28 @@ ConsumerGroup getOrMaybeCreateConsumerGroup(
* Gets or creates a streams group without updating the groups map.
* The group will be materialized during the replay.
*
+ * If there is an empty classic consumer group of the same name, it will
be deleted and a new streams
+ * group.
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
